MantisBT - NetSurf
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002289NetSurfRISC OS-specificpublic2015-03-15 00:012015-11-14 21:06
ReporterSimon Smith 
Assigned To 
PrioritynormalSeverityfeatureReproducibilityalways
StatusclosedResolutionwon't fix 
PlatformOSRISC OSOS Version
Product Version3.4 
Target VersionFixed in Version 
Fixed in CI build #
Reported in CI build #2609
URL of problem pageRISC OS NetSurf config pages, possibly elsewhere, I haven't looked.
Summary0002289: UI inconsistency - don't use no double negatives!
DescriptionThe RISC OS content config window has checkboxes for
'Hide advertisements', 'Disable pop-up windows' and 'Disable Javascript'.
So you have to turn a checkbox /on/ to turn something /off/. That's a double negative, which is confusing UI design.
Please reverse the sense of the checkboxes and adjust their names accordingly.

Show advertisements (default off, I expect)
Allow pop-ups (default off, I guess)
Enable Javascript (default on, I presume)

There may be other inverted config settings here and there (I also saw 'Disable animations', which should be 'Allow animations'. Always phrase things as a positive action, please, never a double negative.

May apply to other platforms.

TagsNo tags attached.
Relationships
Attached Filespatch doubleneg.patch (20,194) 2015-09-07 14:10
https://bugs.netsurf-browser.org/mantis/file_download.php?file_id=320&type=bug

Notes
(0000768)
Vincent Sanders   
2015-03-15 00:22   
Other frontends )gtk/windows) avoid the double negative issue so this is limited to RISC OS
(0000939)
Sprow   
2015-09-07 14:10   
See attached patch which fixes this on the RISC OS frontend.

resources/FatMessages:
Update interactive help with Javascript/Animations sense reversed (the other interactive help was already bland enough to avoid double negatives).

riscos/con_content.c:
Reverse the sense of 'Disable Javascript' to match the internal NetSurf variable sense.

riscos/con_image.c:
Reverse the sense of 'Disable animation' to match the internal NetSurf variable sense.

templates/de,nl,en,fr:
Reverse the senses as above, change wording of "Disable <thing>" with a synonym per the GTK 'Control' preferences tab.
Add the missing "A0-9." validation to the animation speed writeable (fr/de only).
Set the text size to "*" so the Template file compiler fills it in automatically.
Move the "Enable animation" checkbox up above the speed setting which it enables so the eye is drawn down the page when the setting is unfaded.
(0001088)
Dave Higton   
2015-11-14 21:06   
We discussed this issue at the recent Developer Weekend. There is no perfect answer.

The existing scheme has check boxes that are expected NOT to be ticked for the normal case: advertisements allowed, pop-up windows allowed, Javascript enabled.

We chose to continue with the check boxes operation in this sense.

Sprow, I'm sorry that you have done all that abortive work.

Issue History
Date ModifiedUsernameFieldChange
2015-03-15 00:01Simon SmithNew Issue
2015-03-15 00:22Vincent SandersNote Added: 0000768
2015-03-15 00:22Vincent SandersSeverityminor => feature
2015-03-15 00:22Vincent SandersStatusnew => acknowledged
2015-03-15 00:22Vincent SandersCategoryGeneral => RISC OS-specific
2015-03-15 00:22Vincent SandersOS => RISC OS
2015-03-15 00:22Vincent SandersProduct Version => 3.4
2015-03-15 00:22Vincent SandersDescription Updatedbug_revision_view_page.php?rev_id=1439#r1439
2015-09-07 14:10SprowNote Added: 0000939
2015-09-07 14:10SprowFile Added: doubleneg.patch
2015-11-14 21:06Dave HigtonNote Added: 0001088
2015-11-14 21:06Dave HigtonStatusacknowledged => closed
2015-11-14 21:06Dave HigtonResolutionopen => won't fix
2015-11-14 21:06Dave HigtonDescription Updatedbug_revision_view_page.php?rev_id=1707#r1707