MantisBT - NetSurf
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0002219NetSurfRISC OS-specificpublic2014-11-13 12:072016-02-16 15:25
ReporterSprow 
Assigned ToSteve Fryatt 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOSOS Version
Product Version3.2 
Target Version3.4Fixed in Version3.4 
Fixed in CI build #
Reported in CI build #
URL of problem page
Summary0002219: Sprite ptr_lr placed into the main Wimp pool
DescriptionFile '!NetSurf.5Sprites22' and '!NetSurf.!Sprites22' both contain "ptr_lr", this also appears in !NetSurf.Resources.Sprites in your private pool, so the other 2 should be deleted.
TagsNo tags attached.
Relationships
Attached Files

Notes
(0000917)
Sprow   
2015-08-16 08:40   
(Last edited: 2015-08-16 08:41)
Having looked at the reason for this in the code, I see that it's to support the widget in the status bar that sets where the split line is. That uses 'P' validation on the icon, which in turn requires the sprite to be in the Wimp pool. The other uses of the ptr_ sprites are elsewhere in the browser where the private pool is appropriate.

While it would in theory be possible to swap the widget to button type 1 ("always") and replicate the Wimp's logic, this seems a waste of time. Instead, I've requested (and been granted) that ptr_lr be allocated with ROOL so it's now reserved for NetSurf use.

Can close this ticket now.
(0000918)
John-Mark Bell   
2015-08-16 23:52   
Resolved. Thanks!
(0001299)
Vincent Sanders   
2016-02-16 15:25   
Confirmed resolved in 3.4 release

Issue History
Date ModifiedUsernameFieldChange
2014-11-13 12:07SprowNew Issue
2014-11-13 16:49Vincent SandersAssigned To => Steve Fryatt
2014-11-13 16:49Vincent SandersStatusnew => acknowledged
2015-08-16 08:40SprowNote Added: 0000917
2015-08-16 08:41SprowNote Edited: 0000917bug_revision_view_page.php?bugnote_id=917#r1528
2015-08-16 23:52John-Mark BellNote Added: 0000918
2015-08-16 23:52John-Mark BellStatusacknowledged => resolved
2015-08-16 23:52John-Mark BellResolutionopen => no change required
2015-08-16 23:52John-Mark BellFixed in Version => 3.4
2015-08-16 23:52John-Mark BellTarget Version => 3.4
2016-02-16 15:25Vincent SandersNote Added: 0001299
2016-02-16 15:25Vincent SandersStatusresolved => closed